Hi @HiagoVilar
That wasn't exactly what i ment.
That sounds very wrong, since I the introduction of the factory object was a pretty recent thing as far as I remember. I downloaded a clean install of Magento 1.6.0.0 and the code lines didnt match what you described. It does however match the line in 1.9.1.
Did you try and upgrade your install without success?
The file should look like this for 1.6.0.0:
<?php
/**
* Magento
*
* NOTICE OF LICENSE
*
* This source file is subject to the Open Software License (OSL 3.0)
* that is bundled with this package in the file LICENSE.txt.
* It is also available through the world-wide-web at this URL:
* http://opensource.org/licenses/osl-3.0.php
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to license@magentocommerce.com so we can send you a copy immediately.
*
* DISCLAIMER
*
* Do not edit or add to this file if you wish to upgrade Magento to newer
* versions in the future. If you wish to customize Magento for your
* needs please refer to http://www.magentocommerce.com for more information.
*
* @category Mage
* @package Mage_Admin
* @copyright Copyright (c) 2011 Magento Inc. (http://www.magentocommerce.com)
* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
*/
/**
* Auth session model
*
* @category Mage
* @package Mage_Admin
* @author Magento Core Team <core@magentocommerce.com>
*/
class Mage_Admin_Model_Session extends Mage_Core_Model_Session_Abstract
{
/**
* Whether it is the first page after successfull login
*
* @var boolean
*/
protected $_isFirstPageAfterLogin;
/**
* Class constructor
*
*/
public function __construct()
{
$this->init('admin');
}
/**
* Pull out information from session whether there is currently the first page after log in
*
* The idea is to set this value on login(), then redirect happens,
* after that on next request the value is grabbed once the session is initialized
* Since the session is used as a singleton, the value will be in $_isFirstPageAfterLogin until the end of request,
* unless it is reset intentionally from somewhere
*
* @param string $namespace
* @param string $sessionName
* @return Mage_Admin_Model_Session
* @see self::login()
*/
public function init($namespace, $sessionName = null)
{
parent::init($namespace, $sessionName);
$this->isFirstPageAfterLogin();
return $this;
}
/**
* Try to login user in admin
*
* @param string $username
* @param string $password
* @param Mage_Core_Controller_Request_Http $request
* @return Mage_Admin_Model_User|null
*/
public function login($username, $password, $request = null)
{
if (empty($username) || empty($password)) {
return;
}
try {
/* @var $user Mage_Admin_Model_User */
$user = Mage::getModel('admin/user');
$user->login($username, $password);
if ($user->getId()) {
$this->renewSession();
if (Mage::getSingleton('adminhtml/url')->useSecretKey()) {
Mage::getSingleton('adminhtml/url')->renewSecretUrls();
}
$this->setIsFirstPageAfterLogin(true);
$this->setUser($user);
$this->setAcl(Mage::getResourceModel('admin/acl')->loadAcl());
if ($requestUri = $this->_getRequestUri($request)) {
Mage::dispatchEvent('admin_session_user_login_success', array('user' => $user));
header('Location: ' . $requestUri);
exit;
}
}
else {
Mage::throwException(Mage::helper('adminhtml')->__('Invalid Username or Password.'));
}
}
catch (Mage_Core_Exception $e) {
Mage::dispatchEvent('admin_session_user_login_failed',
array('user_name' => $username, 'exception' => $e));
if ($request && !$request->getParam('messageSent')) {
Mage::getSingleton('adminhtml/session')->addError($e->getMessage());
$request->setParam('messageSent', true);
}
}
return $user;
}
/**
* Refresh ACL resources stored in session
*
* @param Mage_Admin_Model_User $user
* @return Mage_Admin_Model_Session
*/
public function refreshAcl($user = null)
{
if (is_null($user)) {
$user = $this->getUser();
}
if (!$user) {
return $this;
}
if (!$this->getAcl() || $user->getReloadAclFlag()) {
$this->setAcl(Mage::getResourceModel('admin/acl')->loadAcl());
}
if ($user->getReloadAclFlag()) {
$user->unsetData('password');
$user->setReloadAclFlag('0')->save();
}
return $this;
}
/**
* Check current user permission on resource and privilege
*
* Mage::getSingleton('admin/session')->isAllowed('admin/catalog')
* Mage::getSingleton('admin/session')->isAllowed('catalog')
*
* @param string $resource
* @param string $privilege
* @return boolean
*/
public function isAllowed($resource, $privilege = null)
{
$user = $this->getUser();
$acl = $this->getAcl();
if ($user && $acl) {
if (!preg_match('/^admin/', $resource)) {
$resource = 'admin/' . $resource;
}
try {
return $acl->isAllowed($user->getAclRole(), $resource, $privilege);
} catch (Exception $e) {
try {
if (!$acl->has($resource)) {
return $acl->isAllowed($user->getAclRole(), null, $privilege);
}
} catch (Exception $e) { }
}
}
return false;
}
/**
* Check if user is logged in
*
* @return boolean
*/
public function isLoggedIn()
{
return $this->getUser() && $this->getUser()->getId();
}
/**
* Check if it is the first page after successfull login
*
* @return boolean
*/
public function isFirstPageAfterLogin()
{
if (is_null($this->_isFirstPageAfterLogin)) {
$this->_isFirstPageAfterLogin = $this->getData('is_first_visit', true);
}
return $this->_isFirstPageAfterLogin;
}
/**
* Setter whether the current/next page should be treated as first page after login
*
* @param bool $value
* @return Mage_Admin_Model_Session
*/
public function setIsFirstPageAfterLogin($value)
{
$this->_isFirstPageAfterLogin = (bool)$value;
return $this->setIsFirstVisit($this->_isFirstPageAfterLogin);
}
/**
* Custom REQUEST_URI logic
*
* @param Mage_Core_Controller_Request_Http $request
* @return string|null
*/
protected function _getRequestUri($request = null)
{
if (Mage::getSingleton('adminhtml/url')->useSecretKey()) {
return Mage::getSingleton('adminhtml/url')->getUrl('*/*/*', array('_current' => true));
} elseif ($request) {
return $request->getRequestUri();
} else {
return null;
}
}
}
