- Mark as New
- Bookmark
- Subscribe
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
who else is fed up with blown up git changesets by copyright changes in magento upgrades?
ok so we all know this: you're patching magento and then we check our git changeset only to find a gazillion files with nonsense changes like this:
why is this a problem?
i have to check which actual changes occured in code and templates so I can see what I have to adapt for my theme and plugins/modules, so i have to go through a ton of files one by one to see if its an actual change or not...
any chance the magento team can stop with this nonsense? I regularly use mass-replace to revert this so I have a chance of real changesets...
who else is fed up by this?
- Mark as New
- Bookmark
- Subscribe
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Re: who else is fed up with blown up git changesets by copyright changes in magento upgrades?
Hi @ludwiggramberg, we're aware of and have heard frustration and pain over this from others in the community. To address this, we've done a couple of things:
- This year we released a copyright release where the only changes made were the copyright: http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.5CE.html
- Starting with 2.2, the copyright year is removed from file headers: https://github.com/magento/magento2/pull/8648
Developer Relations, Adobe Experience Cloud
Problem solved? Click Accept as Solution!
Still stuck? Check out our documentation: https://magento.com/resources/technical
- Mark as New
- Bookmark
- Subscribe
- Subscribe to RSS Feed
- Permalink
- Report Inappropriate Content
Re: who else is fed up with blown up git changesets by copyright changes in magento upgrades?
Hi Sherrie,
unfortunately removing the year isnt enough, remember how you guys changed ownership a few years back (ebay), so the company name changed, so again all files changed.
why can't you do what everyone else is doing? have one file with a license and be done with it. why does every file require any copyright-comment at all? what are you afraid of?
regards
Ludwig