cancel
Showing results for 
Search instead for 
Did you mean: 

Better grunt workflow / local theme.js

0 Kudos

Better grunt workflow / local theme.js

Feature request from amenk, posted on GitHub Sep 29, 2015

When installing a new theme, I would add it to

dev/tools/grunt/configs/themes.js

(according to http://devdocs.magento.com/guides/v2.0/frontend-dev-guide/css-topics/css_debug.html#grunt_prereq)

But this file is in the standard git ignore and would be overwritten when doing a composer update (if Magento is installed via composer)

How can we fix this?

Maybe an additional file custom_themes.js which is included if it exists?

5 Comments
Not applicable
Status changed to: Investigating
 
Not applicable

Comment from amenk, posted on GitHub Sep 29, 2015

see PR https://github.com/magento/magento2/issues/1982

Not applicable

Comment from amenk, posted on GitHub Sep 30, 2015

I am not so happy with my pull request. I was thinking about auto-detecting the installed themes for grunt. But I am not sure if we also can auto detect the locale which is needed for less generation. What do you think?

Not applicable

Comment from amenk, posted on GitHub Oct 14, 2015

I updated my PR #1982 and I am more happy with it now Smiley Happy - please have a look

Not applicable

Comment from guz-anton, posted on GitHub Jul 13, 2016

Just a notice: internal ticket MAGETWO-55345 has been created.