cancel
Showing results for 
Search instead for 
Did you mean: 

Change 'select' to 'query' in AbstractSearchResult

0 Kudos

Change 'select' to 'query' in AbstractSearchResult

Feature request from flancer64, posted on GitHub Jun 15, 2016

Hello,

there is protected property "select" in AbstractSearchResult that is never used

/**
 * @var \Magento\Framework\DB\Select
 */
protected $select;

... and there is 'query' property in the constructor that is not defined:

public function __construct(
    \Magento\Framework\DB\QueryInterface $query,
    ...
) {
    $this->query = $query;
    ...
}

I suppose this code:

/**
 * @var \Magento\Framework\DB\Query
 */
protected $query;

should be instead of 'select' property.