Seems like there are un-necessary dependency added in Below two files
1) Save.php and 2) Data.php
In Save.php file - coreRegistery added in construct function which is actually not needed.
Below is the Re-factor code for Save.php , Copy this code and paste in Save.php
File location - Prince/PincodeChecker/Controller/Adminhtml/Pincodechecker/Save.php
<?php
namespace Prince\PincodeChecker\Controller\Adminhtml\Pincodechecker;
use Magento\Framework\Exception\LocalizedException;
class Save extends \Magento\Backend\App\Action
{
protected $dataPersistor;
/**
* @param \Magento\Backend\App\Action\Context $context
* @param \Magento\Framework\App\Request\DataPersistorInterface $dataPersistor
*/
public function __construct(
\Magento\Backend\App\Action\Context $context,
\Magento\Framework\App\Request\DataPersistorInterface $dataPersistor
) {
$this->dataPersistor = $dataPersistor;
parent::__construct($context);
}
/**
* Save action
*
* @return \Magento\Framework\Controller\ResultInterface
*/
public function execute()
{
/** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
$resultRedirect = $this->resultRedirectFactory->create();
$data = $this->getRequest()->getPostValue();
if ($data) {
$id = $this->getRequest()->getParam('pincode_id');
$model = $this->_objectManager->create('Prince\PincodeChecker\Model\Pincodechecker')->load($id);
if (!$model->getId() && $id) {
$this->messageManager->addError(__('This Pincode no longer exists.'));
return $resultRedirect->setPath('*/*/');
}
$model->setData($data);
try {
$model->save();
$this->messageManager->addSuccess(__('You saved the Pincode.'));
$this->dataPersistor->clear('prince_pincodechecker_pincodechecker');
if ($this->getRequest()->getParam('back')) {
return $resultRedirect->setPath('*/*/edit', ['pincode_id' => $model->getId()]);
}
return $resultRedirect->setPath('*/*/');
} catch (LocalizedException $e) {
$this->messageManager->addError($e->getMessage());
} catch (\Exception $e) {
$this->messageManager->addException($e, __('Something went wrong while saving the Pincode.'));
}
$this->dataPersistor->set('prince_pincodechecker_pincodechecker', $data);
return $resultRedirect->setPath('*/*/edit', ['pincode_id' => $this->getRequest()->getParam('pincode_id')]);
}
return $resultRedirect->setPath('*/*/');
}
}
2) In Data.php file - ScopConfig is there in construct function which is not needed.
Below is the Re-factor code for Data.php , Copy this code and paste in Data.php.
File location - Prince/PincodeChecker/Helper/Data.php
<?php
namespace Prince\PincodeChecker\Helper;
class Data extends \Magento\Framework\App\Helper\AbstractHelper
{
/**
* @var \Prince\PincodeChecker\Model\ResourceModel\Pincodechecker\CollectionFactory
*/
protected $pincodeCollection;
/**
* @var \Magento\Catalog\Model\Product
*/
protected $product;
/**
* @var \Magento\Framework\Controller\ResultFactory
*/
protected $resultFactory;
/**
* @var \Magento\Framework\App\Config\ScopeConfigInterface
*/
protected $scopeConfig;
/**
* Constructor
*
* @param \Magento\Framework\App\Helper\Context $context
* @param \Magento\Catalog\Model\Product $product
* @param \Prince\PincodeChecker\Model\ResourceModel\Pincodechecker\CollectionFactory $pincodeCollection
* @param \Magento\Framework\Controller\ResultFactory $resultFactory
*/
public function __construct(
\Magento\Framework\App\Helper\Context $context,
\Magento\Catalog\Model\Product $product,
\Prince\PincodeChecker\Model\ResourceModel\Pincodechecker\CollectionFactory $pincodeCollection,
\Magento\Framework\Controller\ResultFactory $resultFactory
)
{
$this->pincodeCollection = $pincodeCollection;
$this->product = $product;
$this->resultFactory = $resultFactory;
parent::__construct($context);
}
/**
* Get collection of pincode
*/
public function getCollection()
{
return $this->pincodeCollection->create();
}
/**
* Get pincode status
*/
public function getPincodeStatus($pincode)
{
$collection = $this->getCollection();
$collection->addFieldToFilter('pincode', array('eq' => $pincode));
if($collection->getData()){
return true;
}else{
return false;
}
}
/**
* Get pincode status by product
*/
public function getProductPincodeStatus($id, $pincode)
{
$product = $this->product->load($id);
$pincodes = $product->getData('pincode');
$pincodeArr = explode(',', $pincodes);
if(in_array($pincode, $pincodeArr))
{
return true;
}else{
return false;
}
}
/**
* Get pincode status message
*/
public function getMessage($status, $pincode)
{
if($status){
$message = "<h3>".$this->getSuccessMessage()."</h3>";
}else{
$message = "<h3 style='color:red'>".$this->getFailMessage()."</h3>";
}
return $message;
}
/**
* Get redirect url
*/
public function getRedirect()
{
$resultRedirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
$resultRedirect->setUrl($this->_redirect->getRefererUrl());
return $resultRedirect;
}
/**
* Check module enable
*/
public function getIsEnable()
{
return $this->scopeConfig->getValue('pincode/general/active', \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
}
/**
* Get check on addtocart config value
*/
public function getIsCheckonAddtoCart()
{
return $this->scopeConfig->getValue('pincode/general/checkaddtocart', \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
}
/**
* Get success message config value
*/
public function getSuccessMessage()
{
return $this->scopeConfig->getValue('pincode/general/successmessage', \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
}
/**
* Get fail message config value
*/
public function getFailMessage()
{
return $this->scopeConfig->getValue('pincode/general/failmessage', \Magento\Store\Model\ScopeInterface::SCOPE_STORE);
}
}
if issue solved,Click Kudos & Accept as Solution
