Hello,
I have finally completed the development of an extension that will boost the migration process to Magento. It's related to ranked URLs etc...
Now the issue I'm facing is with the ECQ it found few errors and lots of warnings, so I would appreciate any advice in this regard of the best approach.
I'll attach the report here:
[root@host public_html]# php phpcs.phar --standard=EcgM2 /home/**********/public_html/**********/
FILE: /home/**********/public_html/**********/Console/Command/RegenerateUrlCommand.php
---------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------
34 | WARNING | The method parameter $state is never used
55 | WARNING | The method parameter $inp is never used
73 | WARNING | Model LSD method save() detected in loop
---------------------------------------------------------------------------------------
FILE: /home/**********/public_html/**********/Console/Command/RegenerateCategoryUrlCommand.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------
63 | WARNING | The method parameter $inp is never used
63 | WARNING | The method parameter $out is never used
81 | WARNING | Possible slow SQL method group detected
83 | WARNING | fetchAll() can be memory inefficient for large data sets.
101 | ERROR | Empty CATCH statement detected
-----------------------------------------------------------------------------------------------
FILE: /home/**********/public_html/**********/Console/Command/RegenerateProductUrlCommand.php
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------
58 | WARNING | The method parameter $inp is never used
58 | WARNING | The method parameter $out is never used
79 | WARNING | Possible slow SQL method group detected
81 | WARNING | fetchAll() can be memory inefficient for large data sets.
98 | ERROR | Empty CATCH statement detected
----------------------------------------------------------------------------------------------
FILE: /home/**********/public_html/**********/Model/Category/Plugin/Storage.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
17 | WARNING | The method parameter $object is never used
--------------------------------------------------------------------------------
FILE: /home/**********/public_html/**********/Model/ProductUrlRewriteGenerator.php
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
33 | WARNING | The method parameter $productCategories is never used
-----------------------------------------------------------------------------------
FILE: /home/**********/public_html/**********/Model/Storage/DbStorage.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
73 | WARNING | fetchAll() can be memory inefficient for large data sets.
98 | ERROR | Comment refers to a FIXME task "Get rid of rewrite for root Magento category to unduplicate things"
--------------------------------------------------------------------------------------------------------------------
FILE: /home/**********/public_html/**********/Setup/InstallData.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
30 | WARNING | The method parameter $context is never used
----------------------------------------------------------------------
Looking forward to hearing from you all.
Thanks in advance.
