Typo in message when removing coupon from cart

[apiuser]

Feature request from devonto, posted on GitHub Oct 13, 2016

There is a typo in the message being displayed to a user when removing a coupon code. One 'l' when it should be two in 'cancelled'.

\vendor\magento\module-checkout\Controller\Cart\CouponPost.php line 137 is currently:

$this->messageManager->addSuccess(__('You canceled the coupon code.'));

And should be: $this->messageManager->addSuccess(__('You cancelled the coupon code.'));

[apiuser]

Comment from shanevbg, posted on GitHub Oct 13, 2016

http://grammarist.com/spelling/cancel/ In American English, the verb cancel is usually inflected canceled and canceling—with one l. This is not a rule, however, and exceptions are easily found. In varieties of English from outside the U.S., including Canadian, British, and Australian English, cancelled and cancelling are the preferred spellings.

[apiuser]

Comment from devonto, posted on GitHub Oct 13, 2016

@shanevbg Thanks.

Might it then be more appropriate to build an official en_GB translation pack for these nuances?

[apiuser]

Comment from shanevbg, posted on GitHub Oct 14, 2016

@devonto I would think that would make more sense, than claiming it's "consistent" to use British English piecemeal, for example colour and color (there are many more examples, but I know Magento uses "color" in places).

http://grammarist.com/spelling/color-colour/ Color and colour are different spellings of the same word. Color is the preferred spelling in American English, and colour is preferred in all other main varieties of English.