Hello fellow community members,
Today I raised a GitHub issue regarding the isInStock() method of the Product model. This is highlighting the seemingly erroneous functionality of this method. The assumption that I have made, and which I have seen made in other places by other people, is that this method will return whether or not a product is in stock in the current context. However, inspecting the code it would seem this is not the case, and that instead it's just another method of retrieving whether the product is enabled:
/**
* Whether product available in stock
*
* @return bool
*/
public function isInStock()
{
return $this->getStatus() == \Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED;
}
This seems counterintuitive. The response from the Magento Community Engineering team to the issue report is "this seems to be correct Magento behaviour". Surely it makes more sense for this method to return the actual stock status of the product, given the name of 'isInStock'? At the very least this is going to cause confusion and errors due to assumptions made based on the name and even comment of this method.
What do you think?
Thanks,
Jamie
