SUPEE-11155 patch for Magento 1.9.3.10

[Flipmedia]

I had this error on with the SUPEE-1115: 

checking file js/tiny_mce/plugins/media/js/media.js

Hunk #1 FAILED at 483 (different line endings).

1 out of 1 hunk FAILED

The error indicates that the patch file can not find the suggested patch string, in my case:-

js/tiny_mce/plugins/media/js/media.js

html += option("flash");

NOT

html += option("flash", "object");

The error indicates that this file can not be patched... To fix you can either:-

1. Edit: js/tiny_mce/plugins/media/js/media.js to have the required string

2. Apply the patch to the js/tiny_mce/plugins/media/js/media.js manually then remove that section from the patch file

Normally I would have already removed the failing section from the patch file to confirm that is the problem section and so option 2 suites me.

[Mukesh Tiwari]

Hi @garry_whichello 

It is highly recommended not to use any zipped package from any third party to patch Magento sites.

Always download the patch files from official link https://magento.com/tech-resources/download

For Magento1x patches visit RELEASE ARCHIVES tab.

[Serjudo]

Hello,

The problem is that from the usual download page, does not appear to download the patch 11155 for version 1.9.3.10.

Can you tell us where to download it?

[summers]

Which version of the patch were you using?

[Mukesh Tiwari]

Hi @summers @garry_whichello

@fuzzyjared @Flipmedia 

Please make sure you have applied all previous patches SUPEE-10975 and SUPEE-11086
then apply SUPEE-11155.

I downloaded the fresh version of Magento 1.9.3.10 and applied these patches SUPEE-10975, SUPEE-11086 and SUPEE-11155 in order one by one and there was no error.

For Magento 1.3.9.10 download patch SUPEE-11155 for CE 1.9.3.9 (0 MB) PATCH_SUPEE-11155_CE_1.9.3.9_v3-2019-06-18-08-33-44.sh file

Please see the attached screen shot.

SUPEE-11155

[garry_whichello]

Both patches SUPEE-10975 and SUPEE-11086 were already applied successfully as evidenced from my "applied.patches.list".

I am unable to apply SUPEE-11155 without error.

Guess I will end up doing a fresh install - uggh

[Flipmedia]

First forgive me for posting in "Magento 1.9.3.10"...

Failure of patch to complete indicates the file attempting to be patched, is different from what the patch expects...

@Mukesh Tiwari Your reason of ensuring prior patches are applied is completely correct and one of many reasons for the patch failing.

The client site we were patching is running 1.9.4.1 (so no requirement for prior patches) and the reason for the patch failing was... in the past a .gitignore included "media" as opposed to "/media", thus git had ignored staging "media.js". When the master was pulled from the git repro to staging for patching and upgrade, the media.js remained silently unchanged.

We have since corrected the "greedy" .gitignore rule, staged all files excluded due to "media", from a fresh core 1.9.4.1 download and applied the patch, which executed without error.

@garry_whichello  Actually updating to 1.9.4.1 is not as bigger task as you might think, as long as your able to commit to the odd extension upgraded and provides the added benefit of using PHP7.2... As we near the sunset of M1 and PHP 5.6 is no longer supported this upgrade make perfect sense. The major version upgrade also makes the data migration to M2 viable!

I would suspect that anyone seeing an issue patching media.js who is using git should review their .gitignore file.

[Meetanshi]

Thank you @Vimal Kumar for sharing the patch. 

Hi @garry_whichello,

That must be a false positive. You can manually check the package and you can see the same files which you can see in the official Magento patch. 

However, I downloaded the same file to scan in VirusTotal and here's the result: https://www.virustotal.com/gui/file/b02bf563195609970d6b98ff91d122a5a9276e713655d0c92eaaf7de72da8015...

Here's the screenshot of the VirusTotal result as well if somehow the link given above gets expired: https://drops.meetanshi.com/9ywYmv

By the way, we also these Prepatched files for all the Patches get released over Github as well: https://github.com/MeetanshiInc/Magento-Security-Patches-PrePatched-Files/tree/master/SUPEE-11155

We are investing time in preparing these Prepatched files because they are easy to install for new Magento developers and Magento store owners.

We do recommend using the SSH files for experienced developers. 

Thank you.