Does Magento CE 1.9.3.10 contain the PHP7.2 patch?

[daboss1984]

Hi there,

can someone please tell me, wether the current 1.9.3.10 already contains this PHP patch?

I tried it but I get an error about mcrypt not beeing defined. 

So either the patch is not part of 1.9.3.10 or does not cover the removal of mcrypt from the PHP core. Which one is correct?

Thanks,

Alex

[Manish Mittal]

@daboss1984

This patch is not for Magento CE 1.9.3.10.

[daboss1984]

Thanks for your answer. I know that 1.9.3.10 is not explicitly listed there. But this does not necessarily mean it is not suitable for 1.9.3.10. Probably the documentation just did not get updated.

But what I still don't know is whether it is already included or not (And whether the mcrypt-issue would have been addressed by the patch or not.)

[Manish Mittal]

Its already included in Magento 1.9.3.10. Might be that issue not included in this.

You can follow below link to resolve this issue:

https://magento.stackexchange.com/questions/153759/php-extension-mcrypt-must-be-loaded

[daboss1984]

Thanks. Then it is a bug of the patch/magento...

No, the link does not help. One could get around by installing a corresponding PECL. (What I cannot do at this time). But I think I'll leave it at 5.6 then at this point, until Magento itself solves it or 5.6 is not supported by my provider anymore.

[Manish Mittal]

@daboss1984

I don't think its Magento bug, you have to install mycrypt for php-7.2

https://stackoverflow.com/questions/48275494/issue-in-installing-php7-2-mcrypt

[DazOG]

---

@Manish Mittal wrote:

Its already included in Magento 1.9.3.10. Might be that issue not included in this.

You can follow below link to resolve this issue:

https://magento.stackexchange.com/questions/153759/php-extension-mcrypt-must-be-loaded

---

The PHP 7.2 patch provided by Magento is NOT included in 1.9.3.10.

Magento have stated that it will be included in Magento 1.9.4.0 onwards.

The patch - PATCH-1.9.3.1-1.9.3.9_PHP7-2018-09-13-08-01-43.2_v2 - applies correctly against 1.9.3.10 with no errors or offsets, showing that the code amendments and additions do not already exist in 1.9.3.10.

[daboss1984]

Yes, I also got this information via Email in the meantime. Today, I have the time to do some tests. It looks like it is working now

Since the patch is becoming part of Mage-1.x in 1.9.4 I assume I would have to revert the patch, perform the 1.9.3.10+1 update and then re-apply the patch if any 1.9.3.x-updates are released in the meantime? 

[Manish Mittal]

Great to hear that Let us know if you still face any issue

[DazOG]

---

@daboss1984 wrote:

Yes, I also got this information via Email in the meantime. Today, I have the time to do some tests. It looks like it is working now

Since the patch is becoming part of Mage-1.x in 1.9.4 I assume I would have to revert the patch, perform the 1.9.3.10+1 update and then re-apply the patch if any 1.9.3.x-updates are released in the meantime? 

---

That's an interesting one.  I would presume since it is an optional patch that you would have to revert it if you try and patch 1.9.3.x up to 1.9.4.0.  We'll have to wait and see what they provide when they release 1.9.4.0 I guess.

Also while I remember - a couple of other points found from install & testing:

1. You do not need to (and indeed should not) separately install a mcrypt compatibility library when using PHP 7.2+.  The PHP 7.2 patch provided by Magento bundles one that it uses (lib/mcrypt_compat/mcrypt.php).
   
   
2. The PHP 7.2 patch can be safely applied even if you are not running PHP 7.2 (or indeed PHP 7.x at all).  Magento have tested it against PHP 5.6 without issue.